Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PoC of report-to header #70

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

Firesphere
Copy link
Contributor

@Firesphere Firesphere commented Mar 28, 2023

This is a proof-of-concept of adding a report-to header, resolving issue #63

To do:

  • Ensure the correct header is set in the actual CSP header. It should be the name of the group.
  • Tests
  • Code unification to make methods etc. have a similar name
  • Documentation

Feedback welcome!

@Firesphere Firesphere marked this pull request as ready for review May 26, 2023 03:23
@Firesphere
Copy link
Contributor Author

It is at a "should work" state, I'd like to spend some time updating docs, but I'm lacking time for it :(

@paragonie-security paragonie-security merged commit 17b59da into paragonie:master Dec 18, 2023
@paragonie-security
Copy link
Contributor

The additional dependency broke PHP <7.4 support.

paragonie-security added a commit that referenced this pull request Dec 18, 2023
Undoing the changes in #70 is too annoying right now, and it's high time everyone stopped using PHP <7.4 anyway.

This is going to coincide with a major version bump.
@Firesphere
Copy link
Contributor Author

I personally don't see why 7.4 support should still be a thing moving forward?
For 7.4, there's always the previous version, potentially with a bugfix here and there?

@paragonie-security
Copy link
Contributor

We released v3.x because changing the minimum PHP version is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants