Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: File::encryptData and File::decryptData #133

Merged
merged 2 commits into from Jun 5, 2019

Conversation

elliot-sawyer
Copy link
Contributor

The latest version of Halite contains updated method names.

Consider removing these from the docs, as they're now protected rather than public

The latest version of Halite contains updated method names
@coveralls
Copy link

coveralls commented May 5, 2019

Pull Request Test Coverage Report for Build 734

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.615%

Totals Coverage Status
Change from base Build 731: 0.0%
Covered Lines: 1293
Relevant Lines: 1298

💛 - Coveralls

@christiaan
Copy link

From what I see these fixes also are incorrect. The API is now File::encrypt and File::decrypt

@elliot-sawyer
Copy link
Contributor Author

Good spotting @christiaan, that explains why the methods were protected! I've updated this pull request

@paragonie-scott paragonie-scott merged commit daae21b into paragonie:master Jun 5, 2019
@paragonie-scott
Copy link
Member

Thanks! Good documentation is important for security and you made it materially better than it was before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants