Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpunit 7 came out. #95

Merged
merged 22 commits into from Feb 21, 2018
Merged

phpunit 7 came out. #95

merged 22 commits into from Feb 21, 2018

Conversation

Nenglish7
Copy link
Contributor

@Nenglish7
Copy link
Contributor Author

Coveralls did not update their version constraints yet so it will not work with phpunit 7, but when i do this can be merged after i change the phpunit file to phpunit 7 standards. Been busy so ill try my best to fix up the file.

@Nenglish7
Copy link
Contributor Author

Nenglish7 commented Feb 16, 2018

I do not know how the errors from psalm occurred, could you explain i know nothing about psalm. Everything else works phpunit 7 with coveralls 2.0.0 instead of 1.0.1 build ran perfect except psalm failed.

@coveralls
Copy link

coveralls commented Feb 21, 2018

Pull Request Test Coverage Report for Build 654

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.855%

Totals Coverage Status
Change from base Build 629: 0.0%
Covered Lines: 1373
Relevant Lines: 1375

💛 - Coveralls

@Nenglish7
Copy link
Contributor Author

This is ready to be merged. Errors are gone.

@paragonie-scott paragonie-scott merged commit 9464de2 into paragonie:master Feb 21, 2018
@paragonie-scott
Copy link
Member

Thanks 👍

@Nenglish7 Nenglish7 deleted the patch-5 branch February 21, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants