Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples are wrong? #50

Closed
aidantwoods opened this issue Mar 8, 2018 · 4 comments
Closed

Examples are wrong? #50

aidantwoods opened this issue Mar 8, 2018 · 4 comments

Comments

@aidantwoods
Copy link
Contributor

So I thought I'd add an example from the readme to my test suite, and it turns out there are some typos (unless of course my implementation is somehow completing words and changing a year ;p)

screen shot 2018-03-08 at 19 00 44

I think "exp": should be "expires": and the year should be 2019 instead of 2039.

(correct example)

I would have opened this as a PR, but I wanted to check whether the second example also has the same problem. It appears to, but I can't conclude this because there isn't a public key available to verify the message ;-) (this is a request to add the public key to the readme)

@paragonie-scott
Copy link
Member

I think it's a matter of me updating one but not the other. Good catch. :)

@paragonie-scott
Copy link
Member

I'll have this fixed tonight.

@paragonie-scott
Copy link
Member

d2f8902 -- I included a unit test so we can copy/paste tokens and then verify their correctness if the README is ever changed.

@aidantwoods
Copy link
Contributor Author

Good call on adding the unit tests too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants