Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility between 1.12.0 and earlier version(s) #107

Closed
LukasWieditz opened this issue Nov 7, 2019 · 5 comments
Closed

Incompatibility between 1.12.0 and earlier version(s) #107

LukasWieditz opened this issue Nov 7, 2019 · 5 comments

Comments

@LukasWieditz
Copy link

It appears there is an incompatibility between the latest version of the library and earlier versions, where, if an earlier version is loaded first, the checks performed by the library will not suffice to detect this, and attempt to load elements anew.

The specific issue at hand is caused by a WordPress plugin connecting to a different software that utilizes the latest version of the library, causing WordPress to emit notices and thus breaking the page output:
7bTCTBz

Potentially related to #101

@paragonie-scott
Copy link
Member

It's almost certainly related to #101. However, I have not succeeded in reproducing the environment causing either their problem nor yours, so I'm not sure how helpful I'll be without a tight information feedback loop. Are you willing to help with troubleshooting this?

If so, the first thing I need to know is:

  • Which version of PHP?
  • Which version of Windows?
  • Is OpCache enabled?
  • Does changing line 50 of sodium_compat/autoload.php to check for SODIUM_CRYPTO_SCALARMULT_BYTES instead of SODIUM_LIBRARY_MAJOR_VERSION fix the problem?

@LukasWieditz
Copy link
Author

LukasWieditz commented Nov 7, 2019

Are you willing to help with troubleshooting this?

Absolutely.

Which version of PHP?

7.1.8

Which version of Windows?

W10 Pro Version 1809, Build 17763.805

Is OpCache enabled?

No, not enabled.

Does changing line 50 of sodium_compat/autoload.php to check for SODIUM_CRYPTO_SCALARMULT_BYTES instead of SODIUM_LIBRARY_MAJOR_VERSION fix the problem?

Yes it does.

@paragonie-scott
Copy link
Member

...Interesting! Well, if that easy fix does it, I'm happy with that.

paragonie-security added a commit that referenced this issue Nov 7, 2019
@paragonie-scott
Copy link
Member

Fix landed in v1.12.1, I'll also update the WordPress ticket.

@paragonie-scott
Copy link
Member

https://core.trac.wordpress.org/ticket/48371#comment:5 Thanks for reporting this and your help with confirming my suspicions about a quick fix. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants