Simple Bug Fixes for dvec.h and enuts.h #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few bugs regarding memory leaks (see enuts.h, where one of the vectors wasn't being properly deleted).
Additionally, for a very small penalty, the program can now allocate memory that is initialized to all zeros (using calloc instead of malloc). This avoids nans in the padding regions beyond the physical region. This is especially useful for some mathematical methods that need to always touch beyond boundaries even if they are not used or overwritten. (Matrix multiplication on the blocks is the biggest reason for this addition.)
There was also an issue with dvec exiting too early on inactive meshes which lead to strange behavior when trying to run simulations.