Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build of fresh checkout fails with TypeScript Errors #36

Open
gabrielgrant opened this issue Jun 28, 2017 · 3 comments
Open

Build of fresh checkout fails with TypeScript Errors #36

gabrielgrant opened this issue Jun 28, 2017 · 3 comments
Labels
bug

Comments

@gabrielgrant
Copy link 

$ npm run build

> grpc-bus@ build /home/gabriel/repos/grpc-bus
> tsc && ./scripts/build_touchups.bash

node_modules/@types/jasmine/index.d.ts(113,52): error TS1005: '=' expected.
node_modules/@types/jasmine/index.d.ts(121,62): error TS1005: '=' expected.
node_modules/@types/jasmine/index.d.ts(614,19): error TS1005: ']' expected.
node_modules/@types/jasmine/index.d.ts(614,20): error TS1005: ';' expected.
node_modules/@types/jasmine/index.d.ts(614,21): error TS1128: Declaration or statement expected.
node_modules/@types/jasmine/index.d.ts(697,1): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8599,32): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8602,14): error TS1005: ']' expected.
node_modules/@types/lodash/index.d.ts(8602,15): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8605,26): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8605,42): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8605,61): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8605,66): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8607,15): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8607,25): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8608,23): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8608,46): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8609,22): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8610,9): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8610,10): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8610,21): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8613,18): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8613,32): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8613,45): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8613,55): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8613,83): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8613,87): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8619,23): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8619,32): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8619,46): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8619,68): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8620,22): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8621,10): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8621,21): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8626,24): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8626,34): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8627,23): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8627,32): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8627,46): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8627,68): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8628,22): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8629,10): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8629,21): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8646,29): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8646,75): error TS1005: ']' expected.
node_modules/@types/lodash/index.d.ts(8646,76): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8646,77): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8646,78): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8652,21): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8653,10): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8653,47): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8658,21): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8658,31): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8659,21): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8660,9): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8660,10): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8660,47): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8661,5): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8672,45): error TS1005: ']' expected.
node_modules/@types/lodash/index.d.ts(8672,51): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8672,52): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8672,53): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8672,54): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8675,15): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8675,29): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8675,40): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8675,43): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8675,44): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8675,78): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8681,21): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8682,10): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8682,47): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8687,21): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8687,31): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8688,21): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8689,9): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8689,10): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8689,47): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8690,5): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8704,29): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8704,75): error TS1005: ']' expected.
node_modules/@types/lodash/index.d.ts(8704,76): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8704,77): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8704,78): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8710,21): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8711,10): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8711,47): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8716,21): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8716,31): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8717,21): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8718,9): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8718,10): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8718,47): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8719,5): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8730,45): error TS1005: ']' expected.
node_modules/@types/lodash/index.d.ts(8730,51): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8730,52): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8730,53): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8730,54): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8736,21): error TS1005: ',' expected.
node_modules/@types/lodash/index.d.ts(8737,10): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8737,47): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8742,21): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(8742,31): error TS1109: Expression expected.
node_modules/@types/lodash/index.d.ts(8743,21): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(8744,9): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8744,10): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(8744,47): error TS1005: '(' expected.
node_modules/@types/lodash/index.d.ts(8745,5): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(11844,21): error TS1005: ']' expected.
node_modules/@types/lodash/index.d.ts(11844,22): error TS1005: ';' expected.
node_modules/@types/lodash/index.d.ts(11844,23): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(11844,33): error TS1005: ']' expected.
node_modules/@types/lodash/index.d.ts(11844,34): error TS1005: ')' expected.
node_modules/@types/lodash/index.d.ts(11844,35): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(11844,37): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(11845,5): error TS1128: Declaration or statement expected.
node_modules/@types/lodash/index.d.ts(19926,1): error TS1128: Declaration or statement expected.

npm ERR! Linux 4.4.0-66-generic
npm ERR! argv "/usr/local/heroku/bin/node" "/home/gabriel/.nvm/versions/node/v6.3.0/bin/npm" "run" "build"
npm ERR! node v7.10.0
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR! grpc-bus@ build: `tsc && ./scripts/build_touchups.bash`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the grpc-bus@ build script 'tsc && ./scripts/build_touchups.bash'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the grpc-bus package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc && ./scripts/build_touchups.bash
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs grpc-bus
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls grpc-bus
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/gabriel/repos/grpc-bus/npm-debug.log
@paralin
Copy link
Owner

paralin commented Jun 28, 2017

Interestingly enough those errors are being caused by the @types/lodash package which is not due to an error of this repo...

Probably would be fixed by updating the packages. This repo is a bit out of repair as I haven't had time to work on it since I transitioned to Go from TypeScript on the server side. PRs welcome!

I think the protobuf 6 patch may have broken some things, I had intended to fix them but haven't had a chance.

@gabrielgrant
Copy link
Author

gabrielgrant commented Jun 28, 2017 •
edited
Loading

This actually seems to be resolved by upgrading to TypeScript v2.3.0

Interestingly, the most recent version (2.4.1) seems to fail with a different error:

$ node_modules/.bin/tsc --version
Version 2.4.1
$ npm run build

> grpc-bus@ build /home/gabriel/repos/grpc-bus
> tsc && ./scripts/build_touchups.bash

node_modules/rxjs/Subject.d.ts(16,22): error TS2415: Class 'Subject<T>' incorrectly extends base class 'Observable<T>'.
  Types of property 'lift' are incompatible.
    Type '<R>(operator: Operator<T, R>) => Observable<T>' is not assignable to type '<R>(operator: Operator<T, R>) => Observable<R>'.
      Type 'Observable<T>' is not assignable to type 'Observable<R>'.
        Type 'T' is not assignable to type 'R'.

npm ERR! Linux 4.4.0-66-generic
npm ERR! argv "/usr/local/heroku/bin/node" "/home/gabriel/.nvm/versions/node/v6.3.0/bin/npm" "run" "build"
npm ERR! node v7.10.0
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR! grpc-bus@ build: `tsc && ./scripts/build_touchups.bash`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the grpc-bus@ build script 'tsc && ./scripts/build_touchups.bash'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the grpc-bus package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc && ./scripts/build_touchups.bash
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs grpc-bus
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls grpc-bus
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/gabriel/repos/grpc-bus/npm-debug.log

@gabrielgrant
Copy link
Author

gabrielgrant commented Jun 28, 2017 •
edited
Loading

Yea, I'm currently using the v1.0 release, with protobuf 5, which seems to work fairly well. Ran into the build problem while trying to prep/submit a PR to fix #35

@paralin paralin added the bug label Jun 28, 2017
@gabrielgrant gabrielgrant mentioned this issue Jun 29, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabrielgrant @paralin