Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Number Management #73

Closed
PropGit opened this issue Mar 2, 2017 · 3 comments
Closed

Version Number Management #73

PropGit opened this issue Mar 2, 2017 · 3 comments

Comments

@PropGit
Copy link

PropGit commented Mar 2, 2017

@zfi

From this commit it appears that the version number is currently stored in three different places:

  • BlocklyPropClient.py
  • about.txt
  • package/blocklypropclient-installer.iss

and with the recent enhancement of the Mac build/sign/packaging spec and scripts, it is also necessary for it to be placed in the Info.plist's CFBundleShortVersionString element (currently done automatically at signing/packaging time).

Until/unless we have a way to manage this better in the future, I think I should add a small sed script to the repo that will adjust the version in each of the necessary places in one step- something we can use like this, for example:

  $ set_version 0.5.3

Do you agree with all of this, above?

@PropGit PropGit added this to the March Enhancements milestone Mar 2, 2017
@PropGit
Copy link
Author

PropGit commented Mar 3, 2017

I did this in PR #74. I'll do some final testing/review before merging and closing this issue.

@zfi
Copy link

zfi commented Mar 6, 2017

It looks like PR#74 includes a script that tags a number of files with a specific version number. I'm looking at this from an automated build process. Which file tracks the current version number?

@PropGit
Copy link
Author

PropGit commented Mar 6, 2017

@zfi - Not sure I understand the question. If you're asking which file an automated build process should check for an "official" version number, I'd say it's BlocklyPropClient.py.

@PropGit PropGit closed this as completed Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants