Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the name field of the Key Info Manager optional #479

Open
hug-dev opened this issue Jul 16, 2021 · 1 comment
Open

Make the name field of the Key Info Manager optional #479

hug-dev opened this issue Jul 16, 2021 · 1 comment
Labels
good first issue Good for newcomers medium Effort label

Comments

@hug-dev
Copy link
Member

hug-dev commented Jul 16, 2021

The name field of the key_manager section of the configuration is currently required:

[[key_manager]]
# (Required) Name of the key info manager. Used to tie providers to the manager supporting them.
name = "on-disk-manager"

That name is used for each provider to select it. In some conditions, if there is only one for example, that name could be made optional and all providers would use it directly. The name field could only be required when there is more than one KIM of the same type.

@hug-dev hug-dev added good first issue Good for newcomers medium Effort label labels Jul 16, 2021
@ionut-arm
Copy link
Member

The name field could only be required when there is more than one KIM of the same type.

You need a name if you have multiple KIMs of any type, because otherwise there's no way to tell which one to use for a specific provider (there's no field in provider configs to indicate the type you want to use, just the name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers medium Effort label
Projects
None yet
Development

No branches or pull requests

2 participants