Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the zeroize depdency. #354

Open
Superhepper opened this issue Jun 29, 2022 · 1 comment
Open

Update the zeroize depdency. #354

Superhepper opened this issue Jun 29, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Superhepper
Copy link
Collaborator

Superhepper commented Jun 29, 2022

We should move to a newer version of the Zeroize crate and start using ZeroizeOnDrop in stead of

#[derive(zeroize)]
#[zeroize(drop)]

because it will be deprecated in newer releases.

It would also be a good time to have a look at if all native types that should be using zeroize on drop actually are. And make sure that we allocate the full capacity of the buffers we use to avoid re-allocation of the data which could leave copy of the data in memory.

Read Stack/Heap Zeroing Notes

@Superhepper Superhepper added the enhancement New feature or request label Jun 29, 2022
@Superhepper
Copy link
Collaborator Author

Partially fixed by #378 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant