Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency mbox 0.6.1 which hard requires Rust 2018 #519

Open
jzaehrin opened this issue Apr 11, 2024 · 2 comments
Open

Dependency mbox 0.6.1 which hard requires Rust 2018 #519

jzaehrin opened this issue Apr 11, 2024 · 2 comments

Comments

@jzaehrin
Copy link

jzaehrin commented Apr 11, 2024 •
edited

The release of mbox 0.6.1 now strongly requires Rust 2018 to compile by forcing severely out-dated dependency versions. Version 0.6.0 was yanked from crates.io which blocks the compilation of tss-esapi with a more recent version of Rust and a missing Cargo.lock.

tss-esapi 8.0.0 should replace mbox which is a good thing.

In the meantime, could it be possible to update mbox to 0.7.1 or force 0.6.0?

The difference between 0.6.1 and 0.7.1 is very small, not impacting the code only on the dependencies and compilation context: mbox v0.6.1 commits.
@eugkoira eugkoira mentioned this issue Apr 11, 2024
Closed
@petreeftime
Copy link

#520 Created a PR for this issue.

@Superhepper
Copy link
Collaborator

I think the preferred thing would be to update it.

eugkoira added a commit to eugkoira/aws-nitro-enclaves-cose that referenced this issue Apr 16, 2024
@eugkoira
Update dependencies
ecebedb 
* Bump tss-esapi to the latest version to get rid of dependencies conflicts with KMS SDK
  (More details in parallaxsecond/rust-tss-esapi#519)
* Bump AWS SDK dependencies to their latest versions
* Move aws-config to dev-dependencies because it's used only in tests
* Bump the crate version itself

Signed-off-by: Eugene Koira <eugkoira@amazon.com>
eugkoira added a commit to eugkoira/aws-nitro-enclaves-cose that referenced this issue Apr 16, 2024
@eugkoira
Update dependencies
e04f268 
* Bump tss-esapi to the latest version to get rid of dependencies conflicts with KMS SDK
  (More details in parallaxsecond/rust-tss-esapi#519)
* Bump AWS SDK dependencies to their latest versions
* Move aws-config to dev-dependencies because it's used only in tests
* Bump the crate version itself

Signed-off-by: Eugene Koira <eugkoira@amazon.com>
@eugkoira eugkoira mentioned this issue Apr 16, 2024
Merged
eugkoira added a commit to eugkoira/aws-nitro-enclaves-cose that referenced this issue Apr 16, 2024
@eugkoira
Update dependencies
82ceb1c 
* Bump tss-esapi to the latest version to get rid of dependencies conflicts with KMS SDK
  (More details in parallaxsecond/rust-tss-esapi#519)
* Bump AWS SDK dependencies to their latest versions
* Move aws-config to dev-dependencies because it's used only in tests
* Bump the crate version itself

Signed-off-by: Eugene Koira <eugkoira@amazon.com>
eugkoira added a commit to eugkoira/aws-nitro-enclaves-cose that referenced this issue Apr 16, 2024
@eugkoira
Update dependencies
6cab221 
* Bump tss-esapi to the latest version to get rid of dependencies conflicts with KMS SDK
  (More details in parallaxsecond/rust-tss-esapi#519)
* Bump AWS SDK dependencies to their latest versions
* Move aws-config to dev-dependencies because it's used only in tests
* Bump the crate version itself

Signed-off-by: Eugene Koira <eugkoira@amazon.com>
eugkoira added a commit to eugkoira/aws-nitro-enclaves-cose that referenced this issue Apr 16, 2024
@eugkoira
Update dependencies
08be046 
* Bump tss-esapi to the latest version to get rid of dependencies conflicts with KMS SDK
  (More details in parallaxsecond/rust-tss-esapi#519)
* Bump AWS SDK dependencies to their latest versions
* Move aws-config to dev-dependencies because it's used only in tests
* Bump the crate version itself

Signed-off-by: Eugene Koira <eugkoira@amazon.com>
eugkoira added a commit to eugkoira/aws-nitro-enclaves-cose that referenced this issue Apr 18, 2024
@eugkoira
Update dependencies
cf3d386 
* Bump tss-esapi to the latest version to get rid of dependencies conflicts with KMS SDK
  (More details in parallaxsecond/rust-tss-esapi#519)
* Bump AWS SDK dependencies to their latest versions
* Move aws-config to dev-dependencies because it's used only in tests
* Bump the crate version itself

Signed-off-by: Eugene Koira <eugkoira@amazon.com>
eugkoira added a commit to eugkoira/aws-nitro-enclaves-cose that referenced this issue Apr 18, 2024
@eugkoira
Update dependencies
31b825c 
* Bump tss-esapi to the latest version to get rid of dependencies conflicts with KMS SDK
  (More details in parallaxsecond/rust-tss-esapi#519)
* Bump AWS SDK dependencies to their latest versions (within possible MSRV=1.68.2)
* Move aws-config to dev-dependencies because it's used only in tests
* Bump the crate version itself

Signed-off-by: Eugene Koira <eugkoira@amazon.com>
eugkoira added a commit to awslabs/aws-nitro-enclaves-cose that referenced this issue Apr 18, 2024
@eugkoira
Update dependencies
b12ed3a 
* Bump tss-esapi to the latest version to get rid of dependencies conflicts with KMS SDK
  (More details in parallaxsecond/rust-tss-esapi#519)
* Bump AWS SDK dependencies to their latest versions (within possible MSRV=1.68.2)
* Move aws-config to dev-dependencies because it's used only in tests
* Bump the crate version itself

Signed-off-by: Eugene Koira <eugkoira@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Superhepper @jzaehrin @petreeftime