Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit the ESAPI bindings if the ABI is stable #85

Closed
hug-dev opened this issue Jun 22, 2020 · 4 comments · Fixed by #177
Closed

Commit the ESAPI bindings if the ABI is stable #85

hug-dev opened this issue Jun 22, 2020 · 4 comments · Fixed by #177
Labels
enhancement New feature or request

Comments

@hug-dev
Copy link
Member

hug-dev commented Jun 22, 2020

We should check if the ESAPI ABI is stable and if it is, commit inside the repository (or in tss-esapi-sys) the bindgen bindings that we currently generate everytime during compilation.

That has multiple advantages:

  • make the compilation faster, without the bindgen step
  • simplify the build script
  • we would be able to use for docs.rs
@hug-dev hug-dev added the enhancement New feature or request label Jun 22, 2020
@hug-dev hug-dev added this to To do in Parsec via automation Jun 22, 2020
@ionut-arm
Copy link
Member

Going 180 on this, eh. I think the interface is stable, it's only library changes that might occur so this would make sense (but I do prefer creating a sys crate instead of just committing bindgened code).

@hug-dev
Copy link
Member Author

hug-dev commented Jun 22, 2020

but I do prefer creating a sys crate instead of just committing bindgened code

That would be part of the sys crate still! With only that file in it basically and means to do linking. I had this idea over re-reading this.

@Superhepper
Copy link
Collaborator

So we should use the latest version of tpm2-tss and only generate new bindings when a new version is released? Hrmm how much faster build times are we talking about?

@hug-dev
Copy link
Member Author

hug-dev commented Jun 23, 2020

Well I was hoping that since the TCG TSS 2.0 ESAPI is specified and stable (version 1.0), once the tpm2-tss implementation is compliant there would not be breaking changes with different versions of the implementation, unless the specification itself does a breaking change.
We would say that this crate is a wrapper around version 1.0. and work with all compliant implementations. But maybe it is more complicated than that!

@hug-dev hug-dev added this to the Parsec production ready milestone Aug 7, 2020
@hug-dev hug-dev removed this from the Parsec production ready milestone Sep 2, 2020
@ionut-arm ionut-arm removed this from All issues in Parsec Sep 9, 2020
@hug-dev hug-dev mentioned this issue Nov 11, 2020
4 tasks
@hug-dev hug-dev linked a pull request Jan 26, 2021 that will close this issue
tgonzalezorlandoarm pushed a commit to tgonzalezorlandoarm/rust-tss-esapi that referenced this issue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants