-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset-manager for foreign xcm related assets #1450
Conversation
ghost
commented
Mar 10, 2022
•
edited by ghost
Loading
edited by ghost
- Sync upstream & make it compile
- Integrate into heiko runtime first
- Add some integration test for crosschain transfer
- Add an foreign asset from statemine in this way as demonstration
- Some test in kusama to finalize fee required
- Some refact and add to other runtime
- Some integration test to make sure not break anything previously work
- Revamp retrieving statemine transfer fee from on-chain storage(seems xcm-helper a good option)
- Benchmark
- Temporary remove from heiko and add to kerria first
- Resolve conflicts
- Some test in polkadot network to finalize
this module mainly targets at adding foreign assets from other chains by xcm without code change, though not finished yet but should be fine for review now. @ayushmishra2005 @GopherJ will be appreciated if you can help to review and give some inputs |
Sorry for being busy during the last two weeks due to our app-heiko.parallel.fi deployment, will start reviewing from tomorrow |
require companioned with this pr for statemine asset integration whereas our dependency in master branch is still Line 5114 in b549d6d
|
some test with kusama-local + heiko-dev + statemine-dev
|
Add a seperated folder for integration tests cover foreign asset from other chains |
Refact xcm related config seperately and Integrate with vanilla, focus on kusama related runtimes as first step and leave others for future pr, later change could be referenced from this commit |
In this commit we retrieving MinFee from configurable on-chain storage in |
hi @rocketman1997 I think it's time to merge, can you resolve the comments and conflicts with master etc. Also can you add to vanilla & kerria testnet runtimes first, then we will start to test and integrate into heiko & parallel when feel it's ready |
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
==========================================
- Coverage 67.11% 64.37% -2.74%
==========================================
Files 100 104 +4
Lines 9780 10196 +416
==========================================
Hits 6564 6564
- Misses 3216 3632 +416
Continue to review full report at Codecov.
|