Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset-manager for foreign xcm related assets #1450

Merged
merged 19 commits into from Apr 1, 2022
Merged

Asset-manager for foreign xcm related assets #1450

merged 19 commits into from Apr 1, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2022

  • Sync upstream & make it compile
  • Integrate into heiko runtime first
  • Add some integration test for crosschain transfer
  • Add an foreign asset from statemine in this way as demonstration
  • Some test in kusama to finalize fee required
  • Some refact and add to other runtime
  • Some integration test to make sure not break anything previously work
  • Revamp retrieving statemine transfer fee from on-chain storage(seems xcm-helper a good option)
  • Benchmark
  • Temporary remove from heiko and add to kerria first
  • Resolve conflicts
  • Some test in polkadot network to finalize

@ghost ghost changed the title Integrate asset-manager with heiko runtime first Asset-manager for foreign xcm related assets Mar 15, 2022
@ghost
Copy link
Author

ghost commented Mar 15, 2022

this module mainly targets at adding foreign assets from other chains by xcm without code change, though not finished yet but should be fine for review now. @ayushmishra2005 @GopherJ will be appreciated if you can help to review and give some inputs

@ghost ghost marked this pull request as ready for review March 15, 2022 11:43
pallets/asset-manager/Cargo.toml Outdated Show resolved Hide resolved
@GopherJ
Copy link
Contributor

GopherJ commented Mar 20, 2022

Sorry for being busy during the last two weeks due to our app-heiko.parallel.fi deployment, will start reviewing from tomorrow

pallets/asset-manager/Cargo.toml Outdated Show resolved Hide resolved
pallets/asset-manager/src/tests.rs Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Mar 22, 2022

require companioned with this pr for statemine asset integration whereas our dependency in master branch is still

source = "git+https://github.com/open-web3-stack/open-runtime-module-library.git#aac79b3b31953381669a2ffa9b3e9bfe48e87f38"
and one commit behind,so merge with master and update orml dependencies accordingly

@ghost ghost self-requested a review March 23, 2022 06:43
@ghost
Copy link
Author

ghost commented Mar 23, 2022

some test with kusama-local + heiko-dev + statemine-dev

  • call from statemine to tranfer usdt (1984) to heiko as
0x1f020101010095200100010100d0b7caf571a98a5b970853265ad3b46883e5fffd9e28a83307103e31d50ce74b0104000002043205011f0002093d0000000000
  • call from heiko to transfer usdt(1984) back as
0x2b04086400000000ca9a3b0000000000000000000000006600000040420f000000000000000000000000000000000001010200a10f0100d0b7caf571a98a5b970853265ad3b46883e5fffd9e28a83307103e31d50ce74b00286bee00000000

@ghost
Copy link
Author

ghost commented Mar 25, 2022

Add a seperated folder for integration tests cover foreign asset from other chains

runtime/heiko/src/lib.rs Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Mar 29, 2022

Refact xcm related config seperately and Integrate with vanilla, focus on kusama related runtimes as first step and leave others for future pr, later change could be referenced from this commit

@ghost ghost self-requested a review March 29, 2022 13:30
@ghost
Copy link
Author

ghost commented Mar 29, 2022

In this commit we retrieving MinFee from configurable on-chain storage in XcmHelper instead of hard-coded

@GopherJ
Copy link
Contributor

GopherJ commented Mar 30, 2022

hi @rocketman1997 I think it's time to merge, can you resolve the comments and conflicts with master etc. Also can you add to vanilla & kerria testnet runtimes first, then we will start to test and integrate into heiko & parallel when feel it's ready

@codecov-commenter
Copy link

Codecov Report

Merging #1450 (c90314e) into master (8a15276) will decrease coverage by 2.73%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
- Coverage   67.11%   64.37%   -2.74%     
==========================================
  Files         100      104       +4     
  Lines        9780    10196     +416     
==========================================
  Hits         6564     6564              
- Misses       3216     3632     +416     
Impacted Files Coverage Δ
pallets/asset-manager/src/lib.rs 0.00% <0.00%> (ø)
pallets/asset-manager/src/migrations.rs 0.00% <0.00%> (ø)
pallets/asset-manager/src/weights.rs 0.00% <0.00%> (ø)
pallets/crowdloans/src/mock.rs 61.53% <ø> (ø)
pallets/liquid-staking/src/mock.rs 73.79% <ø> (ø)
pallets/xcm-helper/src/lib.rs 73.25% <0.00%> (-0.58%) ⬇️
primitives/src/currency.rs 0.00% <0.00%> (ø)
primitives/src/lib.rs 100.00% <ø> (ø)
primitives/src/ump.rs 60.00% <ø> (ø)
primitives/src/xcm_gadget.rs 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a15276...c90314e. Read the comment docs.

@ghost
Copy link
Author

ghost commented Mar 31, 2022

@GopherJ @ashi20192020ayush @yz89 I think ready for merge now, please help to final check/review. still some refact/improvement could be done and will add seperate issues to trace and do it in future pr.

@GopherJ GopherJ self-requested a review April 1, 2022 05:27
@GopherJ GopherJ merged commit ff6b80b into parallel-finance:master Apr 1, 2022
@parallel-finance parallel-finance deleted a comment Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants