Add create/1, update/2, and create_comment/2 to Ticket #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmuller
reviewed
Aug 8, 2022
bmuller
approved these changes
Aug 8, 2022
Co-authored-by: Brian Muller <bmuller@parallelmarkets.com>
lannon
approved these changes
Aug 9, 2022
| @@ -5,15 +5,16 @@ defmodule Zendesk.Client.Operation do | |||
| alias Zendesk.Client.Parser | |||
| alias __MODULE__ | |||
|
|
|||
| defstruct path: "/", type: :get, parser: &Parser.default_parse/1, params: [] | |||
| defstruct path: "/", type: :get, parser: &Parser.default_parse/1, params: [], body: nil | |||
There was a problem hiding this comment.
👍
I could engage in more HTTP bike-shedding and suggest that we could send a body with gets, but it'd be pointless and now I'm being super annoying. Apologies. Please don't randomly select me to host the next Happy Hour.
There was a problem hiding this comment.
You're right! But I don't think there are any get endpoints in the API that accept a body, so think we should be good 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.