-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure dependencies are set correctly. #8
Comments
Note this warning:
|
@thoragio thanks, yeah I need to move those to peer dependencies. Or feel free to assign yourself and make a PR if you want 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
react, react-dom, and prop-types should probably be peer dependencies, and they should also probably be in dev dependencies, but not in dependencies.
Check for other dependency corrections as well while updating this.
https://nodejs.org/en/blog/npm/peer-dependencies/
The text was updated successfully, but these errors were encountered: