Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure dependencies are set correctly. #8

Closed
kennylavender opened this issue Aug 13, 2017 · 2 comments · Fixed by #21
Closed

Make sure dependencies are set correctly. #8

kennylavender opened this issue Aug 13, 2017 · 2 comments · Fixed by #21

Comments

@kennylavender
Copy link
Contributor

react, react-dom, and prop-types should probably be peer dependencies, and they should also probably be in dev dependencies, but not in dependencies.

Check for other dependency corrections as well while updating this.

https://nodejs.org/en/blog/npm/peer-dependencies/

@kennylavender kennylavender mentioned this issue Aug 13, 2017
9 tasks
@thoragio
Copy link
Contributor

Note this warning:

npm WARN The package react is included as both a dev and production dependency.
npm WARN The package react-dom is included as both a dev and production dependency.

@kennylavender
Copy link
Contributor Author

kennylavender commented Aug 16, 2017

@thoragio thanks, yeah I need to move those to peer dependencies. Or feel free to assign yourself and make a PR if you want 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants