Add package-lock, nvm use node 8, Travis test node 8 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thoragio cool thx looks good, il just verify it runs on my machine tonight. @ericelliott any thoughts on this? |
kennylavender
approved these changes
Aug 16, 2017
|
We should make sure we're running Node 8 in our CI and prod environments and drop support for Node 6. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kennylavender I'm running node 8.3 and npm 5.3 and have added a package-lock file. I've also added a .nvmrc file to specify the default node version to use for those running nvm.
I've also setup Travis to test using both node 8 & 6.