New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added validation for project Name #166
Conversation
eb8da01
to
fb2db0a
Compare
please review this PR |
8010e18
to
b38f125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hiteshwani29 thanks for your pr, really appreciate your contribution towards paralus. There are a few minor comments, otherwise this looks good.
Also can you ensure you run go fmt before commiting your changes as gh actions are currently failing due to it.
Ensure to update changelog.md as well, you can follow the same format as in the file.
Let me know if you have any doubts.
@hiteshwani29 Issue #149 is similar to this, it can use the same regex validations during cluster creation ? Will it be possible for you to make changes for the same with this pr ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional comments.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 34.68% 34.66% -0.03%
==========================================
Files 74 74
Lines 11671 11682 +11
==========================================
+ Hits 4048 4049 +1
- Misses 7075 7084 +9
- Partials 548 549 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sorry @niravparikh05 I missed this comment but we already have the validation for the cluster name |
@niravparikh05 @akshay196 |
@hiteshwani29 One single change ⬆️ . Otherwise your code looks good to me. |
e003141
to
6afd092
Compare
@akshay196 I don't have merge access. Can you merge this PR and close the issue? |
Waiting for @niravparikh05 to appove. |
ok @akshay196. will wait for him. |
looks good to me, @hiteshwani29 need changelog update and we are good to merge. |
5a78053
to
8dfba8b
Compare
Done @niravparikh05 |
@niravparikh05 After your approval, squash commits and change message to something like |
Signed-off-by: hiteshwani29 <hiteshwani29@gmail.com>
8dfba8b
to
7f9a6be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@hiteshwani29 Thanks for contributing and congratulation on your first PR. 🥳 |
Thanks 🙏 @akshay196 |
What does this PR change?
Does the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.md
go fmt
(if applicable)CHANGELOG.md