New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove references to admindbuser #200
Conversation
Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 34.62% 34.41% -0.21%
==========================================
Files 74 74
Lines 11692 11692
==========================================
- Hits 4048 4024 -24
- Misses 7094 7123 +29
+ Partials 550 545 -5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor changes to be consistent variable names in contribution guide.
Another change which is not in this PR's scope but I just noticed it: Let's remove elasticsearch step from the guide as it is not needed anymore: https://github.com/paralus/paralus/blob/5be0656351857b4e61ad82a39df9f4b7e2f5f7e5/CONTRIBUTING.md#elasticsearch
Co-authored-by: Akshay Gaikwad <akshay196@users.noreply.github.com> Signed-off-by: Nirav Parikh <52062717+niravparikh05@users.noreply.github.com>
Co-authored-by: Akshay Gaikwad <akshay196@users.noreply.github.com> Signed-off-by: Nirav Parikh <52062717+niravparikh05@users.noreply.github.com>
Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
Good catch, have removed this now. |
What does this PR change?
Does the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.md
go fmt
(if applicable)CHANGELOG.md