Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to admindbuser #200

Merged
merged 4 commits into from Apr 27, 2023
Merged

remove references to admindbuser #200

merged 4 commits into from Apr 27, 2023

Conversation

niravparikh05
Copy link
Contributor

What does this PR change?

  • remove references to admindbuser

Does the PR depend on any other PRs or Issues? If yes, please list them.

  • No

Checklist

I confirm, that I have...

  • Read and followed the contributing guide in CONTRIBUTING.md
  • Added tests for this PR
  • Formatted the code using go fmt (if applicable)
  • Updated documentation on the Paralus docs site (if applicable)
  • Updated CHANGELOG.md

Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
@niravparikh05 niravparikh05 linked an issue Apr 13, 2023 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #200 (fe5b21d) into main (0e08492) will decrease coverage by 0.21%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   34.62%   34.41%   -0.21%     
==========================================
  Files          74       74              
  Lines       11692    11692              
==========================================
- Hits         4048     4024      -24     
- Misses       7094     7123      +29     
+ Partials      550      545       -5     

see 1 file with indirect coverage changes

Copy link
Member

@akshay196 akshay196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes to be consistent variable names in contribution guide.

Another change which is not in this PR's scope but I just noticed it: Let's remove elasticsearch step from the guide as it is not needed anymore: https://github.com/paralus/paralus/blob/5be0656351857b4e61ad82a39df9f4b7e2f5f7e5/CONTRIBUTING.md#elasticsearch

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
niravparikh05 and others added 2 commits April 24, 2023 12:47
Co-authored-by: Akshay Gaikwad <akshay196@users.noreply.github.com>
Signed-off-by: Nirav Parikh <52062717+niravparikh05@users.noreply.github.com>
Co-authored-by: Akshay Gaikwad <akshay196@users.noreply.github.com>
Signed-off-by: Nirav Parikh <52062717+niravparikh05@users.noreply.github.com>
Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
@niravparikh05
Copy link
Contributor Author

Few minor changes to be consistent variable names in contribution guide.

Another change which is not in this PR's scope but I just noticed it: Let's remove elasticsearch step from the guide as it is not needed anymore: https://github.com/paralus/paralus/blob/5be0656351857b4e61ad82a39df9f4b7e2f5f7e5/CONTRIBUTING.md#elasticsearch

Good catch, have removed this now.

@akshay196 akshay196 merged commit e203d15 into main Apr 27, 2023
4 checks passed
@akshay196 akshay196 deleted the fix-issue-137 branch April 27, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate-AdminDB Fails With User Not admindbuser
3 participants