New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: relays annotation value is readonly and cannot be updated #227
Conversation
Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 34.65% 34.42% -0.23%
==========================================
Files 74 74
Lines 11694 11694
==========================================
- Hits 4052 4026 -26
- Misses 7093 7123 +30
+ Partials 549 545 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niravparikh05 Please check my comment on the issue: #140 (comment)
…ed review comments Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
@akshay196 thanks for the review comments, after our discussion have made necessary changes. |
Unlinked #140 issue from this PR. |
Need to update db entries for older clusters to move to new logic in this PR After upgrading from 0.2.0 to 0.2.5, we had to go into the database for each clusters annotations and change “relay” to “paralus.dev/relay” or else the bootstrap file would have an empty relay value for the relay-agent-config configmap |
What does this PR change?
Does the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.md
go fmt
(if applicable)CHANGELOG.md