Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relays annotation value is readonly and cannot be updated #227

Merged
merged 3 commits into from Jun 26, 2023

Conversation

niravparikh05
Copy link
Contributor

@niravparikh05 niravparikh05 commented Jun 8, 2023

What does this PR change?

Does the PR depend on any other PRs or Issues? If yes, please list them.

  • No

Checklist

I confirm, that I have...

  • Read and followed the contributing guide in CONTRIBUTING.md
  • Added tests for this PR
  • Formatted the code using go fmt (if applicable)
  • Updated documentation on the Paralus docs site (if applicable)
  • Updated CHANGELOG.md

Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Merging #227 (e214239) into main (59674a2) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   34.65%   34.42%   -0.23%     
==========================================
  Files          74       74              
  Lines       11694    11694              
==========================================
- Hits         4052     4026      -26     
- Misses       7093     7123      +30     
+ Partials      549      545       -4     
Impacted Files Coverage Δ
pkg/service/cluster.go 31.69% <0.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@akshay196 akshay196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niravparikh05 Please check my comment on the issue: #140 (comment)

…ed review comments

Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
@niravparikh05
Copy link
Contributor Author

@akshay196 thanks for the review comments, after our discussion have made necessary changes.

@akshay196 akshay196 merged commit 749dcb4 into main Jun 26, 2023
7 checks passed
@akshay196
Copy link
Member

Unlinked #140 issue from this PR.

@akshay196
Copy link
Member

Need to update db entries for older clusters to move to new logic in this PR

After upgrading from 0.2.0 to 0.2.5, we had to go into the database for each clusters annotations and change “relay” to “paralus.dev/relay” or else the bootstrap file would have an empty relay value for the relay-agent-config configmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants