adding permissions for cli.config.read and code fix for non admin use… #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs cli config download Signed-off-by: Nirav Parikh <nir.parikh05@gmail.com>
akshay196
requested changes
Apr 23, 2024
|
|
||
| err := db.NewSelect().Model(&aps). | ||
| Where("account_id = ?", accountID). | ||
| Where("permission_name = ?", permission). |
There was a problem hiding this comment.
Shouldn't we consider partner_id and organization_id when fetching account details?
There was a problem hiding this comment.
at this point, we have account information from user session. Also until one of the recent release identities does not have partner, organization information - for backward compatibility, we can relay on the logged in user session information.
There was a problem hiding this comment.
looking into a fix which would consider organization, partner information if available otherwise ignore to ensure backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rs cli config download
What does this PR change?
Does the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.mdgo fmt(if applicable)CHANGELOG.md