Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can lib and example be separate? #2

Open
andresn opened this issue Aug 8, 2016 · 1 comment
Open

Can lib and example be separate? #2

andresn opened this issue Aug 8, 2016 · 1 comment

Comments

@andresn
Copy link

andresn commented Aug 8, 2016

Hi @paramaggarwal,

When npm installing, it will pull in the nice example you have, but will also install a redundant react-native dependency within a project. Therefore, I think this project and its users would benefit from being organized more like this one: https://github.com/pwmckenna/react-native-motion-manager. Including matching its installation steps since those seem to be standard across popular RN components.

Thank you in advance for your time!

@paramaggarwal
Copy link
Owner

Yes, good point. I am not actively using this library - so it would be great if we could have a PR raised - or better, maybe a new home for the project managed by someone actively using it.

mik3y added a commit to mik3y/react-native-device-motion that referenced this issue Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants