bug of parsing new format keys

[huashengdun]

From the screenshot above, you see parsing dsa ed25519 keys succeeded, parsing rsa ecdsa keys failed.
The interesting part is parsing rsa key, paramiko recognize it as both rsa and dss type key.

[huashengdun]

generate dsa ecdsa ed25519 rsa private keys

for t in dsa ecdsa ed25519 rsa; do ssh-keygen -t $t -f id_$t -q -N "" && rm *.pub; done

parse.py

import sys
from paramiko import DSSKey, ECDSAKey, Ed25519Key, RSAKey


filenames = sys.argv[1:]
keyclasses = [DSSKey, ECDSAKey, Ed25519Key, RSAKey]


for filename in filenames:
    print('Parsing {}'.format(filename))
    print('='*20)
    for keycls in keyclasses:
        try:
            print(keycls.__name__, end=' ')
            key = keycls(filename=filename)
        except Exception as e:
            print('x')
        else:
            print('√')
        print('-'*20)
    print()

[ploxiln]

The bug with new-format ECDSAKey was mentioned here: #1343 (comment) (and was not addressed in that pull-request, but I think the maintainer was under the impression that it was addressed)

[huashengdun]

Notice the bug of parsing RSA key still has not been fixed yet.
Although paramiko can recognize the RSA type key correctly, but there are still chances that paramiko recognizes the RSA key as the DSS type key.