Added support for aes192-ctr and aes192-cbc #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat, thanks! Mildly surprised nobody bothered adding this earlier when it's as simple as tweaking key size. (Similar to how adding SHA-2 512bit support was a couple lines on top of the work for SHA-2 256.) |
|
Great! It surprised me as well :) |
|
Had to manually apply, the changes for SHA-2 reformatted a bunch of the relevant lines. Made sure to credit in changelog. Thanks again! |
dkhapun
pushed a commit
to cyberx-labs/paramiko
that referenced
this pull request
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for aes192-ctr and aes192-cbc.
I tested the paramiko client against openssh server after setting "Ciphers aes192-ctr" and "aes192-cbc" respectively in sshd_config. Client connected fine, and confirmed the channel was indeed using aes192-ctr. Could execute command and transfer files.
Tested paramiko server by running the demo_server.py and then using the openssh client to connect to it, with option "-c aes192-ctr" or "-c aes192-cbc" respectively.