Add timeout for handshake completion. #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a mechanism for timing out a connection if the ssh banner never completes. pala@amazon.com r:cuthbert@amazon.com
|
@dacut sorry for the late reply! Do you think you can add som tests to this? |
lndbrg
added a commit
to lndbrg/paramiko
that referenced
this pull request
Feb 24, 2015
This is a reimplementation of paramiko#62.
Merged
|
Rolling into #491 |
bitprophet
added a commit
that referenced
this pull request
Sep 30, 2015
dkhapun
pushed a commit
to cyberx-labs/paramiko
that referenced
this pull request
Jun 7, 2018
This is a reimplementation of paramiko#62.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mechanism for timing out a connection if the ssh handshake never completes.
When managing large fleets, we not-infrequently encounter cases where a host is alive enough to accept an SSH connection but not enough to accept commands. (I've seen this with failing disks, for example -- my hypothesis is enough of the ssh daemon is cached in memory, but the shell or other libraries can't be read.)
(Internal p4 CLN 5034409; patch approved for release via TT/0013249552)
author: pala@amazon.com