-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compatibility import cleanup #906
Conversation
Side note: it's a bit odd that the latest version of Fabric supports python2.5, while no supported version of paramiko does. It looks like the last version of paramiko that supported python2.5 was 1.12.4 from May of 2014. |
added in a bit more general import cleanup |
Awesome! Looks good overall. Can you rebase against 1.18 and also open a separate PR against 2.0? For the short term I don't want to leave 1.x folks completely hanging so I'm trying to backport most changes there. (But since it requires carefully cherry-picking to 2.0, so 2.0 doesn't get feature work from 1.18, I'm probably going to stop soon. Or maybe just stop updating 2.0...hrm.) The Fabric thing is largely laziness on my part / the fact that 2.0 is looming. Paramiko got a Py3 compat overhaul in 1.13 which is when it dropped 2.5 support; Fabric 1 can still arguably only work on Python 2 so a user with Paramiko 1.12 and Fabric 1 and Python 2.5 should still be able to operate. |
since python 2.6
found and checked with pyflakes for python2.7 and python3.5
was an un-declared variable too
6a51506
to
964dd6c
Compare
rebased on 1.18 I think it's not worth the effort and confusing git history to up-merge from 1.18 to 2.0, you'll probably want to start doing 1.17/1.18 together and 2.0/2.1/+ together (cherry-picking back to the older "bundle" of branches). Or just cherry-pick back for each, that's not uncommon. |
Yes, that's exactly what I've been doing so far, ever since 1.18/2.1 came out:
It's just that, it's kind of a pain in the rear ;) especially since I had such a strong habit of simply "merge up up up!" from the past. Anyway, I'll do the needful based on this, thank you! |
Remove try/except blocks which were for supporting old versions of python which paramiko no longer supports.
cStringIO was actually used unconditionally before the python3 port: 0b7d0cf