Parse host keys with more than one space or tab #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keachi
force-pushed
the
hostkey_split
branch
5 times, most recently
from
8e7f511
to
17ab01e
Compare
bskinn
suggested changes
Mar 14, 2023
keachi
force-pushed
the
hostkey_split
branch
5 times, most recently
from
89cc3be
to
8023ee9
Compare
|
Great, thanks for taking care of these, @keachi! One thing left - this is worthy of a CHANGELOG entry -- please add one to |
OpenSSH allows to have more than one whitespace between host and keytype or between keytype and base64-encoded key. Whitespaces may consists of spaces and/or tabs. https://man.openbsd.org/sshd.8#AUTHORIZED_KEYS_FILE_FORMAT
|
Fully agree. I added the changelog entry. |
|
Flagged for bitprophet review. Thanks, @keachi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #2204.
known_hosts with more than one whitespace or tab are supported by OpenSSH. This should be the case of Paramiko as well.