This repository has been archived by the owner on Apr 28, 2024. It is now read-only.
#110 improve code quality/mongoqueryengine/queryengine #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the missing code and rechecked all the functions and cases, now they all cases check for the config.CreateLogFn and run it. I also noticed I misnamed the receiver variables as mqw vs mqe, so I updated that to remain consistent with the other functions. |
|
Awesome! Looks good 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to issue #110
Refactored code to switch statements and smaller functions that manage each query result and handle errors.
This should be both easier to manage as well as add to in the future.
I tested all the function implementations after running 'wails dev' and using the linux gui and it worked the same as it did when I ran against the main branch.
Please let me know if you have any suggested changes. If you're okay with the changes I'll go ahead and work on the next issue on codefactor.