Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port shaders to WGSL #141

Closed
parasyte opened this issue Feb 28, 2021 · 1 comment · Fixed by #172
Closed

Port shaders to WGSL #141

parasyte opened this issue Feb 28, 2021 · 1 comment · Fixed by #172
Assignees
Labels
enhancement New feature or request

Comments

@parasyte
Copy link
Owner

This is a followup to #134 (comment)

I have an experimental Work In Progress that uses a slightly older version of naga to compile the WGSL. It needs to be updated with the latest changes contributed by the community, which includes wgpu 0.7. I haven't published a branch for it, yet. It needs some cleanup and updates.

The experimental WIP uses wgpu 0.6, so I had to compile WGSL to SPIR-V before passing the shader to wgpu. 0.7 is able to accept WGSL directly without the intermediate compilation step. There may also have been some syntax changes to WGSL since I last worked on it.

Finally, only the shader for the scaling renderer has been ported. The custom shader example still needs work.

@parasyte parasyte added the enhancement New feature or request label Feb 28, 2021
@parasyte parasyte self-assigned this Jun 5, 2021
@parasyte
Copy link
Owner Author

parasyte commented Jun 5, 2021

I'm going to want this before starting on #170. It's going to need an example with a custom shader and I would rather not write it twice in two different languages. I already have to rewrite the shaders for the scaling renderer and the custom shader example!

And recent naga releases should have fixed some of the outstanding issues I ran into last time. Now is a good time to pick up this work again.

parasyte added a commit that referenced this issue Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant