Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wgpu 0.9 #179

Merged
merged 7 commits into from
Jun 27, 2021
Merged

Update to wgpu 0.9 #179

merged 7 commits into from
Jun 27, 2021

Conversation

parasyte
Copy link
Owner

@parasyte parasyte commented Jun 23, 2021

  • Will not pass CI yet; needs imgui-wgpu update
  • That's fixed, now just waiting for upstream release.

- Will not pass CI yet; needs imgui-wgpu update
- The wgpu update for this crate is being upstreamed in Yatekii/imgui-wgpu-rs#58
@JMS55
Copy link
Contributor

JMS55 commented Jun 23, 2021

Btw there's an include_wgsl!() macro now.
Also, I'm getting a crash trying to use this branch of pixels in my game. ScalingRenderer::new::device.create_shader_module() is causing an error.

@parasyte
Copy link
Owner Author

Thanks for the reminder! I'm going to include that soon. The error in the scaling renderer is because I didn't actually run any of the examples while doing this work. I was just looking at compile errors at the time.

- This moves the hardcoded vertex positions and texture coordinates to
  the vertex buffer.
- Replaces the two-triangle quad to 1 full-screen triangle (fixes #180)
- Rewrites the custom shader example to fix a bug with large surface
  textures;
  - The input texture size was used for the output texture, causing the
    purple rectangle to appear very jumpy on large displays in full screen.
- The `ScalingRenderer` now exposes its clipping rectangle. The custom
  shader example uses this for its own clipping rectangle, but it can
  also be used for interacting with the border in general.
- This is a nice little simplification.
- Thanks to @JMS55 for the suggestion!
@parasyte parasyte marked this pull request as ready for review June 24, 2021 03:01
@parasyte
Copy link
Owner Author

@JMS55 If you would like to give this another look and 👍 I'm ready to merge it!

@JMS55
Copy link
Contributor

JMS55 commented Jun 26, 2021

LGTM!

@parasyte parasyte merged commit c4df23f into master Jun 27, 2021
@parasyte parasyte deleted the wgpu/0.9 branch June 27, 2021 18:09
@hw762
Copy link

hw762 commented Jul 15, 2021

Would this be released soon? I am trying the pixels/egui for my project, but the released version depends on 0.8.1, causing conflict.

@parasyte
Copy link
Owner Author

The plan is to cut the next release following #182.

In the meantime, you can pin the pixels dependency with a git revision; this will work as long as you don't need to release your crate to crates.io:

[dependencies]
pixels = { git = "https://github.com/parasyte/pixels.git", rev = "ce549a79b69ecaaf325552b5a56fdcdaaa530f3b" }

@parasyte
Copy link
Owner Author

@hw762 I released pixels 0.5.0 today. Sorry for the wait!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants