-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WrapperRunner randomly throwing a Fatal Error #54
Comments
FindingsWhen To reproducecheck out tripsta/paratest/issues/54-wrapper-runner-exception and run bin/paratest -p 2 --runner WrapperRunner test/fixtures/tests/EnvironmentTest.php Example of exceptionworker count in startWorkers 2 Example of successworker count in startWorkers 2 Time: 0 seconds, Memory: 3.25Mb OK (2 tests, 6 assertions) |
Thank you for the investigation, since it can be reproduced I'll try to fix |
@giorgiosironi Is the above fix OK?
|
Yes, the fix is ok as this is a race condition between $this->pending and "more workers than pending tests" being available in a single shot. I'll look at master and see if I can reproduce the issue. |
I'll download a 5.3 VM to get the same problem. |
Reproduced on 5.3.10, with a similar test. Symfony/Process has a default timeout of 60 seconds for a process (don't know between which events it is measured), and that stops the suite. |
I got a green build here: |
Its OK. Thumbs up! |
The error below happened on this travis build
It also happens on my dev (on around 70% of the runs) machine when running
The text was updated successfully, but these errors were encountered: