Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for testsuite parameter (#142) #144

Merged
merged 5 commits into from
Jan 31, 2015
Merged

add support for testsuite parameter (#142) #144

merged 5 commits into from
Jan 31, 2015

Conversation

chbiel
Copy link
Contributor

@chbiel chbiel commented Jan 29, 2015

make it possible to spedify a testsuite within phpunit.xml with attributes and execute the specified 's in parallel

@julianseeger
Copy link
Contributor

Nice, thanks for this.

I'm just wondering about files but not directories. Your patch supports suites with files but doesn't support directories, does it? (https://phpunit.de/manual/current/en/organizing-tests.html#organizing-tests.xml-configuration)
Actually, I haven't seen a testsuite with files in practice. Is it much harder to add directory support? If not, it would be nice if you could add it.

…s (also supports mixing of files+directories)
@chbiel
Copy link
Contributor Author

chbiel commented Jan 29, 2015

No problem, I need this for a project with many legacy tests with messed up test structure ;)

I added directory support and (apparently) support for mixed file/directory suites.
I wasn't sure if I should make it complicated with another option to filter duplicates (when mixing files and directories) so I forced, that no duplicate tests are allowed when using --testsuite parameter.

It's important to mention, that the 's are not executed in order as mentioned in the phpunit docs. For paratests it is only to add specific files to a testsuite that will be also executed.

@julianseeger
Copy link
Contributor

I wasn't sure if I should make it complicated with another option to filter duplicates (when mixing files and directories) so I forced, that no duplicate tests are allowed when using --testsuite parameter.

Sounds good. Getting an error is better than having duplicates because of a senseless config and not noticing it.

It's important to mention, that the 's are not executed in order as mentioned in the phpunit docs. For paratests it is only to add specific files to a testsuite that will be also executed.

The order is always mixed up when parallelizing the tests, so +1 for that.

Thanks again and this in going to be version 0.10.0

julianseeger added a commit that referenced this pull request Jan 31, 2015
@julianseeger julianseeger merged commit 5b3c939 into paratestphp:master Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants