Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Unit tests over Functional ones #511

Merged
merged 19 commits into from Aug 21, 2020

Conversation

Slamdunk
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #511 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #511      +/-   ##
=============================================
+ Coverage     99.82%   100.00%   +0.17%     
+ Complexity      555       533      -22     
=============================================
  Files            28        28              
  Lines          1703      1641      -62     
=============================================
- Hits           1700      1641      -59     
+ Misses            3         0       -3     
Impacted Files Coverage Δ Complexity Δ
src/Runners/PHPUnit/Worker/RunnerWorker.php 100.00% <ø> (ø) 13.00 <0.00> (ø)
src/Console/Commands/ParaTestCommand.php 100.00% <100.00%> (ø) 11.00 <0.00> (-2.00)
src/Parser/Parser.php 100.00% <100.00%> (ø) 11.00 <1.00> (-11.00)
src/Runners/PHPUnit/BaseWrapperRunner.php 100.00% <100.00%> (ø) 3.00 <1.00> (-2.00)
src/Runners/PHPUnit/Options.php 100.00% <100.00%> (ø) 81.00 <0.00> (ø)
src/Runners/PHPUnit/ResultPrinter.php 100.00% <100.00%> (ø) 58.00 <0.00> (ø)
src/Runners/PHPUnit/Runner.php 100.00% <100.00%> (+1.31%) 24.00 <5.00> (-7.00) ⬆️
src/Runners/PHPUnit/SqliteRunner.php 100.00% <100.00%> (ø) 16.00 <0.00> (ø)
src/Runners/PHPUnit/SuiteLoader.php 100.00% <100.00%> (ø) 69.00 <0.00> (ø)
src/Runners/PHPUnit/Worker/BaseWorker.php 100.00% <100.00%> (+1.47%) 19.00 <8.00> (-6.00) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0e5e6...c22c010. Read the comment docs.

@Slamdunk Slamdunk marked this pull request as ready for review August 21, 2020 08:24
@Slamdunk Slamdunk merged commit a6ad22d into paratestphp:master Aug 21, 2020
@Slamdunk Slamdunk deleted the functional_to_unit branch August 21, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant