Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate FidryCpuCoreCounter #703

Merged
merged 2 commits into from Dec 12, 2022

Conversation

theofidry
Copy link
Contributor

See theofidry/cpu-core-counter#11 for the motivations.

The code should be sensibly the same, the notable differences are:

  • fixed the deprecated usage of hw.ncpu
  • /proc/cpuinfo is check last
  • nproc is checked first (before was not checked at all, it's considered to be more accurate and less convoluted than cpuinfo though)

I would also wait on 1.x before merging this if you're happy with it. Technically the current version is fine, I'm just looking for a round of feedback before publishing 1.0.

@Slamdunk
Copy link
Member

Slamdunk commented Dec 5, 2022

Fine by me 💪

ParaTest follows PHPUnit's PHP support, so I need your package to support PHP 7.3 as well

@theofidry
Copy link
Contributor Author

Will have to add support for PHP 7.2 for PHPStan anyway so let's do it :)

@theofidry theofidry force-pushed the feature/cpu-core-counter branch 2 times, most recently from 772e592 to 33c5146 Compare December 11, 2022 00:18
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #703 (0915342) into 6.x (a096be1) will decrease coverage by 0.11%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##                6.x     #703      +/-   ##
============================================
- Coverage     99.88%   99.77%   -0.12%     
+ Complexity      622      619       -3     
============================================
  Files            31       31              
  Lines          1792     1788       -4     
============================================
- Hits           1790     1784       -6     
- Misses            2        4       +2     
Impacted Files Coverage Δ
src/Runners/PHPUnit/Options.php 99.46% <33.33%> (-0.54%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@theofidry
Copy link
Contributor Author

Should be good now!

@Slamdunk Slamdunk merged commit 1db5cc1 into paratestphp:6.x Dec 12, 2022
@Slamdunk
Copy link
Member

Thank you @theofidry

@theofidry theofidry deleted the feature/cpu-core-counter branch December 12, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants