Skip to content

Commit

Permalink
Fix minor issues
Browse files Browse the repository at this point in the history
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
  • Loading branch information
kakkoyun committed Feb 23, 2022
1 parent 8fa44df commit bfa82f4
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions pkg/profiler/profiler.go
Original file line number Diff line number Diff line change
Expand Up @@ -443,9 +443,12 @@ func (p *CgroupProfiler) profileLoop(ctx context.Context, captureTime time.Time)
level.Debug(p.logger).Log("msg", "failed to get mapping", "err", err)
}

objFile, err := p.objCache.ObjectFileForProcess(pid, m)
if err != nil {
level.Debug(p.logger).Log("msg", "failed to open object file", "err", err)
var objFile *objectfile.ObjectFile
if m != nil {
objFile, err = p.objCache.ObjectFileForProcess(pid, m)
if err != nil {
level.Debug(p.logger).Log("msg", "failed to open object file", "err", err)
}
}

// Transform the address by normalizing OS offsets.
Expand All @@ -454,8 +457,11 @@ func (p *CgroupProfiler) profileLoop(ctx context.Context, captureTime time.Time)
nAddr, err := objFile.ObjAddr(addr)
if err != nil {
level.Debug(p.logger).Log("msg", "failed to get normalized address from object file", "err", err)
} else {
// TODO(kakkoyun): Remove!
level.Debug(p.logger).Log("msg", "transforming address", "pid", pid, "addr", addr, "normalizedAddr", normalizedAddr)
normalizedAddr = nAddr
}
normalizedAddr = nAddr
}
l := &profile.Location{
ID: uint64(locationIndex + 1),
Expand Down

0 comments on commit bfa82f4

Please sign in to comment.