fix golang-ci lints

parca-dev · Nov 24, 2022 · c07d9d3 · c07d9d3
1 parent 460158f
commit c07d9d3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/pkg/buildid/buildid.go b/pkg/buildid/buildid.go
@@ -44,8 +44,6 @@ func BuildID(f *elf.File, path string) (string, error) {
 	}
 
 	if hasGoBuildIDSection {
-		//f.Close()
-
 		if id, err := fastGoBuildID(f); err == nil && len(id) > 0 {
 			return hex.EncodeToString(id), nil
 		}
@@ -57,8 +55,6 @@ func BuildID(f *elf.File, path string) (string, error) {
 
 		return hex.EncodeToString([]byte(id)), nil
 	}
-	//f.Close()
-
 	if id, err := fastGNUBuildID(f); err == nil && len(id) > 0 {
 		return hex.EncodeToString(id), nil
 	}

diff --git a/pkg/process/maps.go b/pkg/process/maps.go
@@ -104,16 +104,16 @@ func (c *mappingFileCache) mappingForPID(pid int) ([]*profile.Mapping, error) {
 
 			abs := path.Join(fmt.Sprintf("/proc/%d/root", pid), m.File)
 
-			f_elf, err := elf.Open(abs)
+			fElf, err := elf.Open(abs)
 			if err != nil {
 				if !errors.Is(err, os.ErrNotExist) {
 					level.Debug(c.logger).Log("msg", "failed to read object elf file", "object", abs, "err", err)
 				}
 				continue
 			}
-			defer f_elf.Close()
+			defer fElf.Close()
 
-			m.BuildID, err = buildid.BuildID(f_elf, abs)
+			m.BuildID, err = buildid.BuildID(fElf, abs)
 			if err != nil {
 				if !errors.Is(err, os.ErrNotExist) {
 					level.Debug(c.logger).Log("msg", "failed to read object build ID", "object", abs, "err", err)