-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/cpu: Reduce .text section error spam #1864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
reviewed
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice yes this is exactly the type of direction I was thinking of.
kakkoyun
reviewed
Jul 18, 2023
Sylfrena
force-pushed
the
delightful-logs-track
branch
from
July 19, 2023 11:01
dbf5227
to
58c229b
Compare
brancz
reviewed
Jul 19, 2023
Sylfrena
force-pushed
the
delightful-logs-track
branch
2 times, most recently
from
July 20, 2023 08:20
bd55bcf
to
32e3057
Compare
brancz
reviewed
Jul 20, 2023
Sylfrena
force-pushed
the
delightful-logs-track
branch
from
July 22, 2023 13:12
661cf58
to
4831f1e
Compare
Sylfrena
commented
Jul 22, 2023
Sylfrena
force-pushed
the
delightful-logs-track
branch
from
July 24, 2023 06:55
9497106
to
1079c1f
Compare
brancz
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1857
Why?
User report that logs are being spammed with
in #1857
What?
Add a counter to keep track of said error and only logs it once every 50 times we hit the error case to reduce spamming the logs in default logging mode.
馃 Generated by Copilot at 502844c
-->