pkg/runtime: Prevent allocations from searching symbol tables #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
approved these changes
Aug 2, 2023
Before this patch searching symbol tables allocated a lot of memory in one allocation which caused heap to spike dramatically at the start.
brancz
force-pushed
the
symbol-search-alloc
branch
from
5680b81
to
dd4807d
Compare
brancz
force-pushed
the
symbol-search-alloc
branch
from
c68d664
to
ccfd074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Before this patch searching symbol tables allocated a lot of memory in one allocation which caused heap to spike dramatically at the start.
What? / How?
Same strategy as in xyproto/ainur#5
Remove big bulk allocation.
Test Plan
Haven't tested other than compiling.