tests: Add integration tests for mixed-mode unwinding #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierhonduco
force-pushed
the
add-integration-test-for-jit
branch
from
853c949
to
9a968b1
Compare
|
Mmm the JITed stacks are consistently failing in CI... |
|
I have added some comments. I haven't checked the failures, but one of those could be the reason for the constant failure. |
kakkoyun
reviewed
Aug 23, 2023
It's unrelated to the test commit I added to test some hypothesis. Before, it was failing with empty JIT stacks |
javierhonduco
force-pushed
the
add-integration-test-for-jit
branch
3 times, most recently
from
21e2558
to
435a1ef
Compare
aka JIT <-> DWARF unwinding. This also tests that the symbolization using perfdump works. Note that asserting on the JIT stacks is temporarily disabled in CI as it's consistently failing and we have other features to work on that are higher priority. Landing this now will at least ensure that this is tested locally. Will make sure that this CI exception is lifted once we have more time. Also changed the running time for the profiler during non-CI runs to reduce feedback cycles. Signed-off-by: Francisco Javier Honduvilla Coto <javierhonduco@gmail.com>
javierhonduco
force-pushed
the
add-integration-test-for-jit
branch
from
bd41776
to
ec2fe0d
Compare
|
In the spirit of pragmatism I have disabled the assertions of JIT'd stacks in CI. Will fix this later on. With these changes, we will test these code paths locally, and the iteration times will be reduced, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aka JIT <-> DWARF unwinding. This also tests that the symbolization using
perfdump works.
Also changed the running time for the profiler during non-CI runs to
reduce feedback cycles.