pkg/stack/unwind: Handle undefined return addresses in arm64 compact unwind table #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sylfrena
changed the title
… Arm64 `rbpType` is not set correctly in case of Undefined Return Address in Link Register causing unwinding an extra frame despite reaching bottom frame(main()). This was not caught by any tests in #1953(#1953) so add tests as well. TEST PLAN ========= Before: ``` === RUN TestCompactUnwindTableArm64/RA_Rule_undefined compact_unwind_table_test.go:217: Error Trace: /Users/icebear/Snow/polar/parca-agent/pkg/stack/unwind/compact_unwind_table_test.go:217 Error: Not equal: expected: unwind.CompactUnwindTable{unwind.CompactUnwindTableRow{pc:0x7b, lrOffset:0, cfaType :0x1, rbpType:0x0, cfaOffset:0, rbpOffset:0}} actual : unwind.CompactUnwindTable{unwind.CompactUnwindTableRow{pc:0x7b, lrOffset:0, cfaType :0x2, rbpType:0x4, cfaOffset:0, rbpOffset:0}} --- FAIL: TestCompactUnwindTableArm64/RA_Rule_undefined (0.00s) === RUN TestCompactUnwindTableX86/RA_Rule_undefined compact_unwind_table_test.go:407: Error Trace: /Users/icebear/Snow/polar/parca-agent/pkg/stack/unwind/compact_unwind_table_test.go:407 Error: Not equal: expected: unwind.CompactUnwindTable{unwind.CompactUnwindTableRow{pc:0x7b, lrOffset:-16, cfaType :0x2, rbpType:0x4, cfaOffset:0, rbpOffset:0}} actual : unwind.CompactUnwindTable{unwind.CompactUnwindTableRow{pc:0x7b, lrOffset:0, cfaType :0x1, rbpType:0x0, cfaOffset:0, rbpOffset:0}} --- FAIL: TestCompactUnwindTableX86/RA_Rule_undefined (0.00s) ``` After: ``` - PASS: TestCompactUnwindTableX86 (0.00s) - PASS: TestCompactUnwindTableX86/CFA_with_Offset_on_x86_64_stack_pointer (0.00s) - PASS: TestCompactUnwindTableX86/CFA_with_Offset_on_x86_64_frame_pointer (0.00s) - PASS: TestCompactUnwindTableX86/CFA_known_expression_PLT_1 (0.00s) - PASS: TestCompactUnwindTableX86/CFA_known_expression_PLT_2 (0.00s) - PASS: TestCompactUnwindTableX86/CFA_not_known_expression (0.00s) - PASS: TestCompactUnwindTableX86/RA_Rule_undefined (0.00s) - PASS: TestCompactUnwindTableX86/RBP_offset (0.00s) - PASS: TestCompactUnwindTableX86/RBP_register (0.00s) - PASS: TestCompactUnwindTableX86/RBP_expression (0.00s) - PASS: TestCompactUnwindTableX86/Invalid_CFA_rule_returns_error (0.00s) -- PASS: TestCompactUnwindTableArm64 (0.00s) - PASS: TestCompactUnwindTableArm64/CFA_with_Offset_on_Arm64_stack_pointer (0.00s) - PASS: TestCompactUnwindTableArm64/CFA_with_Offset_on_Arm64_frame_pointer (0.00s) - PASS: TestCompactUnwindTableArm64/CFA_known_expression_PLT_1 (0.00s) - PASS: TestCompactUnwindTableArm64/CFA_known_expression_PLT_2 (0.00s) - PASS: TestCompactUnwindTableArm64/CFA_not_known_expression (0.00s) - PASS: TestCompactUnwindTableArm64/RA_Rule_undefined (0.00s) - PASS: TestCompactUnwindTableArm64/RBP_offset (0.00s) - PASS: TestCompactUnwindTableArm64/RBP_register (0.00s) - PASS: TestCompactUnwindTableArm64/RBP_expression (0.00s) - PASS: TestCompactUnwindTableArm64/Invalid_CFA_rule_returns_error (0.00s) ``` Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Sylfrena
force-pushed
the
fix-undefined-ra
branch
from
971ad1a
to
dcbe447
Compare
javierhonduco
approved these changes
Sep 14, 2023
Sylfrena
changed the title
Sylfrena
added a commit
to parca-dev/testdata
that referenced
this pull request
Sep 14, 2023
xref: parca-dev/parca-agent#2015 Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Sylfrena
added a commit
to parca-dev/testdata
that referenced
this pull request
Sep 14, 2023
…ies (#20) * testdata: Add Arm64 libc.so binaries and updated tables for cpp binaries xref: parca-dev/parca-agent#2015 Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rbpTypeis not set correctly in case of Undefined Return Address in Link Register causing unwinding an extra frame despite reaching bottom frame(main()).This was not caught by any tests in #1953(#1953) so add tests as well.
TEST PLAN
Before:
After: