-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Add more CPU profiler metrics #2041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you provide the metrics in the test plan? Something like curling the metrics endpoint and showing that the counters we care about are there
Added them to description |
e580dfc
to
8c59743
Compare
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
8c59743
to
6daf8ba
Compare
Why?
We want to track more metrics for the failure modes of the BPF code.
This PR also includes some code re-organization to separate components semantically.
What?
Refactor the CPU profiler and the BPF-related code to use new packages and improve logging, error handling, and metrics.
Test Plan
make test/profiler
Relevant metrics