unwind info: Implement opcode for return addres signing #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In arm64, `DW_CFA_AARCH64_negate_ra_state` which shares the same value as `DW_CFA_GNU_window_save` in SPARC, is used to indicate a signed return address. Note that we just implement the opcode handling, the unwinder remains unchanged. Test Plan ========= Added regression test Signed-off-by: Francisco Javier Honduvilla Coto <javierhonduco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In arm64,
DW_CFA_AARCH64_negate_ra_statewhich shares the same value asDW_CFA_GNU_window_savein SPARC, is used to indicate a signed return address.Note that we just implement the opcode handling, the unwinder remains unchanged.
Fixes #2181
Test Plan
Added regression test