Utilize Docker layer cache #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
force-pushed
the
utilize_buildcache
branch
from
48dcc78
to
c915f7d
Compare
brancz
reviewed
Sep 2, 2021
| @@ -14,11 +14,15 @@ RUN apt-get -o Acquire::Check-Valid-Until="false" update -y && apt-get install - | |||
| ln -s /usr/bin/clang-11 /usr/bin/clang && \ | |||
| ln -s /usr/bin/llc-11 /usr/bin/llc | |||
| WORKDIR /parca-agent | |||
| COPY parca-agent.bpf.c vmlinux.h Makefile go.mod go.sum /parca-agent/ | |||
| COPY ./3rdparty /parca-agent/3rdparty | |||
| RUN make bpf | |||
There was a problem hiding this comment.
I honestly don't remember anymore what the exact reason was there but this was the only order I could make it consistently work. I'm happy to have us open an issue for this to investigate again though.
There was a problem hiding this comment.
Shall I close this PR and open an issue? This was annoying me while running parca-agent with Tilt.
There was a problem hiding this comment.
If we can get something to work I'm more than happy to merge, I just remember spending some time on it and getting nowhere, but that was quite a while ago so might very well be misremembering entirely.
There was a problem hiding this comment.
I'll keep an eye on this in case it breaks anything.
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
utilize_buildcache
branch
from
c915f7d
to
b675450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com