feat(snap): ensure snapd restarts service if the agent crashes #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the change!! Please do let us know if you have experienced any crashes in your environment. Feel free to open issues at assign them to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
If a user starts Parca Agent with
snap start parca-agentand the agent crashes, currently it stays dormant.What?
A simple change to the systemd configuration for the snap daemon
How?
馃 Generated by Copilot at dc2bd8e
parca-agentservice to always (link). This improves the reliability and availability of the agent, which collects and sends profiling data to the Parca server. The change was discussed and agreed upon in issue Bump k8s.io/apimachinery from 0.20.6 to 0.22.2聽#62.Test Plan