Enable Python and Ruby Unwinding by default #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
enable_ruby_and_python_default
branch
from
a4e5157
to
c9a7d7f
Compare
| @@ -177,6 +174,12 @@ Flags: | |||
| object files from disk. It keeps FDs open, | |||
| so it should be kept in sync with ulimits. | |||
| 0 means no limit. | |||
| --dwarf-unwinding-disable Do not unwind using .eh_frame information. | |||
There was a problem hiding this comment.
Nit: Perhaps we should make all this "positive", swapping them all to "[whatever]-enable" so it's clear when we want to disable it, rather than having "--thing-disable=false" which might be harder to understand
There was a problem hiding this comment.
I used "disable" because of our existing flags and since it's enable by default.
javierhonduco
approved these changes
Nov 29, 2023
| EnablePythonUnwinding bool `default:"false" help:"Enable Python unwinding." hidden:""` | ||
| EnableRubyUnwinding bool `default:"false" help:"Enable Ruby unwinding." hidden:""` | ||
| EnablePythonUnwinding bool `default:"false" help:"[deprecated] Python unwinder enabled by default. Use --python-unwinding-disable to disable it." hidden:""` | ||
| EnableRubyUnwinding bool `default:"false" help:"[deprecated] Ruby unwinder enabled by default. Use --ruby-unwinding-disable to disable it." hidden:""` |
There was a problem hiding this comment.
Happy it you prefer to remove it now and add it to the release notes as a backwards incompatible change, your call!
There was a problem hiding this comment.
We can add it to the changelog and we can remove it in subsequent releases.
There was a problem hiding this comment.
Completely up to you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
depends: