Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/perf: Prevent intermediate perfmap/jitdump entry lists #2325

Merged
merged 1 commit into from
Dec 1, 2023
Merged

pkg/perf: Prevent intermediate perfmap/jitdump entry lists #2325

merged 1 commit into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. pkg/perf: Prevent intermediate perfmap/jitdump entry lists 

    Previously we maintained multiple lists of perfmap and jitdump entries
as well as all related strings. This caused somewhat large memory spikes
when a lot of these have to be loaded frequently.

Now strings are never on heap and are directly written to the optimized
symtab file, and only entries are loaded into memory once so they can be
sorted and deduplicated easily and then without any further intermediate
lists directly written to the optimized symtab file.

If this is also not sufficient the next optimization would be to read
perfmap files from the back and directly write entries that are read if
they don't conflict with any already written memory ranges.
    @brancz
    brancz committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    9b6e508 View commit details
    Browse the repository at this point in the history