Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrated to new otelgrpc API for tracing #2329

Merged
merged 3 commits into from
Dec 19, 2023
Merged

migrated to new otelgrpc API for tracing #2329

merged 3 commits into from
Dec 19, 2023

Conversation

Namanl2001
Copy link
Contributor

@Namanl2001 Namanl2001 commented Dec 2, 2023 •
edited

Why?

Fixes : #2237

What?

migrated to new otelgrpc API for tracing.

Took reference from here

How?

Test Plan

Screen shots from jaeger UI run using scripts/local-observability

image

image

@Namanl2001
new otel grpc API for tracing
e4916a1 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001 Namanl2001 requested a review from a team as a code owner December 2, 2023 20:36
kakkoyun
kakkoyun reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Have you tested this? Does everything work as expected? If so, could you add a screenshot from Jaeger UI?

FYI, We have a local setup for running Jaeger locally under "scripts/local-observability" (though it might need some love).

pkg/grpc/conn.go Outdated Show resolved Hide resolved
@Namanl2001
removed lint check
1af3d92 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001
Copy link
Contributor Author

Looking good.

Have you tested this? Does everything work as expected? If so, could you add a screenshot from Jaeger UI?

FYI, We have a local setup for running Jaeger locally under "scripts/local-observability" (though it might need some love).

Thanks for the pointers to test the changes. Added screenshots to PR description from jaeger UI

@kakkoyun kakkoyun merged commit c0c0c9b into parca-dev:main Dec 19, 2023
22 checks passed
@Namanl2001 Namanl2001 deleted the new-otel-grpc-api branch December 25, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tracing: Migrate to new otelgrpc tracing APIs
2 participants
@Namanl2001 @kakkoyun