-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Build Pipeline: Use Zig as compiler #2395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devbox + direnv is a pretty neat combo! The overall strategy of this change makes a ton of sense to me. |
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
I think you mentioned that Zig doesn't allow for statically built libc, what is the current state of things with this PR? Sorry if I misunderstood something! |
For what I see in the PR, it seems like we are using musl for the native C dependencies as our libc, not GNUs, is that correct? |
kakkoyun
added a commit
that referenced
this pull request
Jan 4, 2024
Use zig as compiler Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
added a commit
that referenced
this pull request
Jan 9, 2024
Use zig as compiler Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
added a commit
that referenced
this pull request
Jan 9, 2024
Use zig as compiler Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR compiles dependencies, using Zig Build System.
Note
This targets https://github.com/parca-dev/parca-agent/tree/nbp_devbox
As of now, it doesn't address cross-compilation concerns.
musl
and statically links everything.