Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache executables for unwind tables to speed up CGI-like workloads #2517

Merged
merged 1 commit into from Feb 19, 2024
Merged

Cache executables for unwind tables to speed up CGI-like workloads #2517

merged 1 commit into from Feb 19, 2024

Conversation

gnurizen
Copy link
Contributor

No description provided.

@gnurizen gnurizen marked this pull request as ready for review February 17, 2024 17:45
@gnurizen gnurizen requested a review from a team as a code owner February 17, 2024 17:45
@gnurizen
Copy link
Contributor Author

gnurizen commented Feb 17, 2024 •
edited

I didn't have any luck reproducting the users parca-agent profile, something about it I must be missing, but this SHOULD address it, basically just implemented @kakkoyun's suggestion. Thanks for pointing me in the right direction @kakkoyun!

kakkoyun
kakkoyun approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🏆 🥇 💯

@kakkoyun kakkoyun merged commit 2090d53 into parca-dev:main Feb 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@brancz brancz brancz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnurizen @kakkoyun @brancz