pkg/profiler: hack to fix double-registration panic #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
reviewed
Feb 23, 2022
kakkoyun
reviewed
Feb 23, 2022
There was a problem hiding this comment.
When that re-review this, after @metalmatze and I talked, I think we shouldn't pass the counter while we already passing the reg. We just need to add a label.
While this does fix the double registration panic issue, further work needs to be done to expose relevant labels. Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Sylfrena
force-pushed
the
fix-double-registration-panic
branch
from
6f19aed
to
1b854c2
Compare
kakkoyun
changed the title
|
I apologize for only getting to this now, but I don't think this is 100% correct. The problem is that this metric never gets unregistered when the profiler is stopped. I believe the only way to fix this correctly is to pass the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sumera Priyadarsini sylphrenadin@gmail.com
Fix #255