discovery: Support systems without systemd #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, we only supported discovering cgroups via systemd by reading /proc/$PID/cgroup: ``` [...] 1:name=systemd:/kubepods/burstable/pod1fa4240d-10d4-494f-88d2-80a639e26ac5/de86e0bfc1f648084db99ead71c756df43ec7e936342144c61d58961859a564b [...] ``` On systems running openrc for instance, that line doesn't exist. Instead we have: ``` 1:name=openrc:/docker ``` With this, parca-agent would discover the __cgroup_path__ for the job to be `/sys/fs/cgroup/perf_event`, leading to parca-agent profiling everything for every pod. This commit adds logic to support discovering the cgroup via perf_event. If the system is running systemd, it'll always fall back to using that line as it is the second from the last. Fixes parca-dev#268
|
|
|
Awesome! Thank you so much for having a look into this! lgtm 🎉 cc @kakkoyun any comments from your side? |
|
Thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, we only supported discovering cgroups via systemd by
reading /proc/$PID/cgroup:
On systems running openrc for instance, that line doesn't exist. Instead
we have:
With this, parca-agent would discover the cgroup_path for the job to
be
/sys/fs/cgroup/perf_event, leading to parca-agent profilingeverything for every pod.
This commit adds logic to support discovering the cgroup via perf_event.
If the system is running systemd, it'll always fall back to using that
line as it is the second from the last.
Fixes #268